RFR: 8294623: gtests does not work with googletest release-1.12.0+

Dingli Zhang dzhang at openjdk.org
Wed Oct 12 01:52:33 UTC 2022


On Mon, 10 Oct 2022 23:36:38 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> @DingliZhang According to the building.md documentation:
>> 
>> The supported version of Google Test is 1.8.1, whose source code can be obtained:
>> 
>>  * by downloading and unpacking the source bundle from [here](https://github.com/google/googletest/releases/tag/release-1.8.1)
>>  * or by checking out `release-1.8.1` tag of `googletest` project: `git clone -b release-1.8.1 https://github.com/google/googletest`
>> 
>> I don't know how old version 1.8.1 is or whether we need to expand on the supported releases here. Maybe the build folk will have an opinion? @magicus or @erikj79 .
>
>> I don't know how old version 1.8.1 is or whether we need to expand on the supported releases here. Maybe the build folk will have an opinion? @magicus or @erikj79 .
> 
> I don't think we need to support multiple versions of googletest.  I don't see any benefit, and doing so incurs costs.  It might be that we should update to using a newer version, but that's a very different discussion.

@kimbarrett @magicus @rose00 Thanks for review!

I apologize for the incomplete error report due to an oversight on my part. At first I misread `Gtest` section in `doc/building.md `, only read `Gtest` section in `doc/testing.md` and used version 1.10.0 of `Gtest`. When I found out that there was a newer version of googletest I made an attempt and found the problem.

I later found out that the `doc/building.md` pointed out the supported versions of gtest and thought it would be a convenient move for developers to support latest versions of gtest.

I think it is a good idea:
> Perhaps the Gtest section in doc/testing.md should cross-link to the section quoted above in doc/building.md

Thank you all for helping me in your busy schedule! I will close this PR.

-------------

PR: https://git.openjdk.org/jdk/pull/10503


More information about the hotspot-runtime-dev mailing list