RFR: JDK-8295412 : support latest VS2022 MSC_VER in abstract_vm_version.cpp

Magnus Ihse Bursie ihse at openjdk.org
Thu Oct 20 14:30:56 UTC 2022


On Tue, 18 Oct 2022 02:04:04 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Currently the latest VS2022 versions are not supported when checking _MSC_VER in abstract_vm_version.cpp, that should be improved.
>> See
>> https://learn.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=msvc-170
>> https://learn.microsoft.com/de-de/visualstudio/install/visual-studio-build-numbers-and-release-dates?view=vs-2022
>> Visual Studio 2022 version 17.3 1933
>> Visual Studio 2022 version 17.2 1932
>
> Looks fine and trivial.
> 
> It is so annoying we need to do this. :(

@dholmes-ora Why do you do this? If it needs to be done it should probably be extracted by the build system and sent into Hotspot as a define. But before I'd try to fix that, the first question is: do we really need this value?

-------------

PR: https://git.openjdk.org/jdk/pull/10727


More information about the hotspot-runtime-dev mailing list