RFR: JDK-8295412 : support latest VS2022 MSC_VER in abstract_vm_version.cpp

David Holmes dholmes at openjdk.org
Fri Oct 21 03:41:55 UTC 2022


On Thu, 20 Oct 2022 14:28:28 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Looks fine and trivial.
>> 
>> It is so annoying we need to do this. :(
>
> @dholmes-ora Why do you do this? If it needs to be done it should probably be extracted by the build system and sent into Hotspot as a define. But before I'd try to fix that, the first question is: do we really need this value?

@magicus it is used to report the compiler version in hotspot internal version string (-Xinternalversion) in a clear way i.e.

MS VC++ 17.3 (VS2022)

versus

unknown MS VC++:  1933

 AFAIK MSC doesn't provide any exported means to map the build numbers back to a nice version string like this.

-------------

PR: https://git.openjdk.org/jdk/pull/10727


More information about the hotspot-runtime-dev mailing list