RFR: JDK-8293472: Potentially incorrect container resource limit detection if manual cgroup fs mounts present [v8]

[Severin Gehwolf]

On Tue, 13 Sep 2022 06:12:41 GMT, 王超 <duke at openjdk.org> wrote:

>> Similar to [JDK-8253435](https://bugs.openjdk.org/browse/JDK-8253435), when setting the mount path of cgroup controller "memory/cpu/cpuacct/pids", it should also discard duplicate items.
>
> 王超 has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix typo

Looks good to me. Feel free to add the suggestion.

src/hotspot/os/linux/cgroupSubsystem_linux.cpp line 304:

> 302:     //
> 303:     if (is_cgroupsV2 && sscanf(p, "%*d %*d %*d:%*d %*s %s %*[^-]- %s %*s %*s", tmp_mount_point, tmp_fs_type) == 2) {
> 304:       // we likely have an early match return (e.g. cgroup fs match), be sure we have cgroup2 as fstype

Please re-instate this comment. It's still valid and the reason why we string compare to `cgroup2`

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR: https://git.openjdk.org/jdk/pull/10193