RFR: JDK-8293472: Incorrect container resource limit detection if manual cgroup fs mounts present [v9]

王超 duke at openjdk.org
Wed Sep 14 01:17:59 UTC 2022


On Tue, 13 Sep 2022 14:36:20 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> 王超 has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Re-instate the comment
>
> src/hotspot/os/linux/cgroupSubsystem_linux.cpp line 304:
> 
>> 302:     //
>> 303:     if (is_cgroupsV2 && sscanf(p, "%*d %*d %*d:%*d %*s %s %*[^-]- %s %*s %*s", tmp_mount_point, tmp_fs_type) == 2) {
>> 304:       // we likely have an early match return (e.g. cgroup fs match), be sure we have cgroup2 as fstype
> 
> Please re-instate this comment. It's still valid and the reason why we string compare to `cgroup2`

Done. Thank you for your patience review.

-------------

PR: https://git.openjdk.org/jdk/pull/10193


More information about the hotspot-runtime-dev mailing list