RFR: 8274166: Some CDS tests ignore -Dtest.cds.runtime.options [v2]

Matias Saavedra Silva matsaave at openjdk.org
Tue Apr 4 16:44:58 UTC 2023


> The test.cds.runtime.options property is used to execute the CDS tests in a special mode. E.g., create the archived with G1 but load the archive with EpsilonGC.
> 
> Currently tests that are launched with TestCommon.runWithArchive() and CDSTestUtils.runWithArchive() can handle -Dtest.cds.runtime.options. However, some test cases, such as dynamicArchive/HelloDynamic.java, do not call the above two methods, so they ignore -Dtest.cds.runtime.options.
> 
> The fix is to move the handling of -Dtest.cds.runtime.options to TestCommon.executeAndLog, because most CDS tests use this function to launch a child JVM. Other considerations are necessary now that the option is exposed to other tests, so checks for GC and CDS are necessary. Verified with tier1-4 tests.

Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:

  Design suggestions

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/13273/files
  - new: https://git.openjdk.org/jdk/pull/13273/files/7c9a2fee..c153fc49

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=13273&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=13273&range=00-01

  Stats: 72 lines in 1 file changed: 23 ins; 33 del; 16 mod
  Patch: https://git.openjdk.org/jdk/pull/13273.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/13273/head:pull/13273

PR: https://git.openjdk.org/jdk/pull/13273


More information about the hotspot-runtime-dev mailing list