RFR: 8274166: Some CDS tests ignore -Dtest.cds.runtime.options [v3]
Matias Saavedra Silva
matsaave at openjdk.org
Tue Apr 4 17:22:15 UTC 2023
> The test.cds.runtime.options property is used to execute the CDS tests in a special mode. E.g., create the archived with G1 but load the archive with EpsilonGC.
>
> Currently tests that are launched with TestCommon.runWithArchive() and CDSTestUtils.runWithArchive() can handle -Dtest.cds.runtime.options. However, some test cases, such as dynamicArchive/HelloDynamic.java, do not call the above two methods, so they ignore -Dtest.cds.runtime.options.
>
> The fix is to move the handling of -Dtest.cds.runtime.options to TestCommon.executeAndLog, because most CDS tests use this function to launch a child JVM. Other considerations are necessary now that the option is exposed to other tests, so checks for GC and CDS are necessary. Verified with tier1-4 tests.
Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
Added improved comments
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/13273/files
- new: https://git.openjdk.org/jdk/pull/13273/files/c153fc49..00fb167b
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=13273&range=02
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=13273&range=01-02
Stats: 17 lines in 1 file changed: 17 ins; 0 del; 0 mod
Patch: https://git.openjdk.org/jdk/pull/13273.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/13273/head:pull/13273
PR: https://git.openjdk.org/jdk/pull/13273
More information about the hotspot-runtime-dev
mailing list