RFR: 8274166: Some CDS tests ignore -Dtest.cds.runtime.options [v4]
Ioi Lam
iklam at openjdk.org
Tue Apr 4 21:58:08 UTC 2023
On Tue, 4 Apr 2023 21:23:38 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:
>> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fixed indentation and removed unused imports
>
> test/lib/jdk/test/lib/cds/CDSTestUtils.java line 614:
>
>> 612:
>> 613: // -Xshare options are likely at the end of the args list
>> 614: for (int i = cmd.size() - 1; i >= 0; i--) {
>
> nit
> Suggestion:
>
> for (int i = cmd.size() - 1; i >= 0; i--) {
The condition can be "i >= 1" since we know cmd.get(0) is the "java" launcher.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13273#discussion_r1157806170
More information about the hotspot-runtime-dev
mailing list