RFR: 8303422: Use a common functions to exit the VM for -Xshare:dump and CDS errors

[Frederic Parain]

On Thu, 13 Apr 2023 15:19:03 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

> Currently, we have ad-hoc calls to os::_exit(0), vm_exit_during_initialization() and vm_direct_exit() in cases where there are dumptime or runtime errors for CDS. This patch introduces intuitively named methods for exiting the VM when there are dumptime/runtime errors and when dumping is finished. Verified with tier 1-4 tests.

src/hotspot/share/cds/metaspaceShared.cpp line 685:

> 683:                      java_lang_String::as_utf8_string(java_lang_Throwable::message(PENDING_EXCEPTION)));
> 684:       MetaspaceShared::unrecoverable_writing_error("VM exits due to exception, use -Xlog:cds,exceptions=trace for detail");
> 685:       //vm_exit_during_initialization(-1, "VM exits due to exception, use -Xlog:cds,exceptions=trace for detail");

Commented line should be removed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13463#discussion_r1165742445