RFR: 8303422: Use a common functions to exit the VM for -Xshare:dump and CDS errors

[Coleen Phillimore]

On Thu, 13 Apr 2023 15:19:03 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

> Currently, we have ad-hoc calls to os::_exit(0), vm_exit_during_initialization() and vm_direct_exit() in cases where there are dumptime or runtime errors for CDS. This patch introduces intuitively named methods for exiting the VM when there are dumptime/runtime errors and when dumping is finished. Verified with tier 1-4 tests.

src/hotspot/share/classfile/stringTable.cpp line 800:

> 798:       // but bail out for safety.
> 799:       log_error(cds)("Too many strings to be archived: " SIZE_FORMAT, _items_count);
> 800:       MetaspaceShared::unrecoverable_writing_error("");

I think these calls to unrecoverable_writing_error should have the string above as argument rather than "".  The "" looks odd.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13463#discussion_r1165998369