RFR: 8305922: [aix,linux] Avoid comparing 'this' to nullptr
Tyler Steele
tsteele at openjdk.org
Mon Apr 24 18:08:54 UTC 2023
On Thu, 13 Apr 2023 09:29:52 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:
>> This PR removes the remaining 'this' vs. 'nullptr' checks from osThread_linux.cpp and osThread_aix.cpp which cause a build warning on AIX and Linux (when building with Clang). My grepping finds no other occurrences.
>>
>> As the warning indicates, `this` cannot be `nullptr` in well-formed C++ code. Previous issues have removed these checks, and I believe it makes sense to do so again in these places.
>
> LGTM.
Thanks for the reviews @TheRealMDoerr and @dholmes-ora.
I am not familiar with the RFE process. Should I wait before integrating this change?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/13448#issuecomment-1520606662
More information about the hotspot-runtime-dev
mailing list