RFR: 8313435: Clean up unused default methods code

[Kim Barrett]

On Tue, 1 Aug 2023 00:48:42 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

> Default methods processing code has unused code (that gets -Wconversion warnings) from when it was used to create bridge (called overpass) method for an early implementation of generic reification in Hotspot.
> 
> This change removes unused bytecodeAssembler code and adds a check for methods and constant pool overflow.
> Tested with tier1 and runtime/lambda-features tests.

Looks good, except for a couple of oddly formatted parameter lists.

src/hotspot/share/classfile/bytecodeAssembler.cpp line 164:

> 162: 
> 163: int BytecodeAssembler::assemble_method_error(
> 164:     BytecodeConstantPool* cp, BytecodeBuffer* buffer, Symbol* errorName, Symbol* message) {

Again here, oddly indented parameter list.

src/hotspot/share/classfile/bytecodeAssembler.hpp line 195:

> 193: 
> 194:   static int assemble_method_error(
> 195:     BytecodeConstantPool* cp, BytecodeBuffer* buffer, Symbol* errorName, Symbol* message);

I think the more usual way to format the multi-line parameter list is

static int assemble_method_error(BytecodeConstantPool* cp,
(line up under prev param) --->     BytecodeBuffer* buffer,
(line up under prev param) --->     Symbol* errorName,
(line up under prev param) --->     Symbol* message);

-------------

Marked as reviewed by kbarrett (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15095#pullrequestreview-1557224783
PR Review Comment: https://git.openjdk.org/jdk/pull/15095#discussion_r1280784658
PR Review Comment: https://git.openjdk.org/jdk/pull/15095#discussion_r1280779611