RFR: 8313435: Clean up unused default methods code [v2]

[Coleen Phillimore]

On Tue, 1 Aug 2023 15:06:37 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Align parameters.
>
> src/hotspot/share/classfile/bytecodeAssembler.cpp line 164:
> 
>> 162: 
>> 163: int BytecodeAssembler::assemble_method_error(
>> 164:     BytecodeConstantPool* cp, BytecodeBuffer* buffer, Symbol* errorName, Symbol* message) {
> 
> Again here, oddly indented parameter list.

Same here.

> src/hotspot/share/classfile/bytecodeAssembler.hpp line 195:
> 
>> 193: 
>> 194:   static int assemble_method_error(
>> 195:     BytecodeConstantPool* cp, BytecodeBuffer* buffer, Symbol* errorName, Symbol* message);
> 
> I think the more usual way to format the multi-line parameter list is
> 
> static int assemble_method_error(BytecodeConstantPool* cp,
> (line up under prev param) --->     BytecodeBuffer* buffer,
> (line up under prev param) --->     Symbol* errorName,
> (line up under prev param) --->     Symbol* message);

I fixed this.  This code was copied/moved from the other file with the odd formatting.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15095#discussion_r1280834196
PR Review Comment: https://git.openjdk.org/jdk/pull/15095#discussion_r1280834013