RFR: 8304292: Memory leak related to ClassLoader::update_class_path_entry_list [v2]

Calvin Cheung ccheung at openjdk.org
Thu Aug 3 22:09:49 UTC 2023


On Thu, 3 Aug 2023 07:29:45 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   add comments to boolean args
>
> src/hotspot/share/classfile/classLoader.cpp line 524:
> 
>> 522:   while (cp_stream.has_next()) {
>> 523:     const char* path = cp_stream.get_next();
>> 524:     update_class_path_entry_list(current, path, true, false, false);
> 
> Some comments on these boolean parameters would be useful.

I added some comments to the above and another callsite in the same file.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15132#discussion_r1283762515


More information about the hotspot-runtime-dev mailing list