RFR: 8304292: Memory leak related to ClassLoader::update_class_path_entry_list [v2]

Calvin Cheung ccheung at openjdk.org
Thu Aug 3 22:09:48 UTC 2023


> Please review this small fix for `ClassPathEntry` leak when there's a duplicate entry in the app class path (`-cp`) and the `check_for_duplicate` argument is set to `true`, the `ClassLoader::add_to_app_classpath_entries` function should delete the entry before returning. This fix also corrects the call to `update_class_path_entry_list` from `setup_app_search_path`; the `check_for_duplicate` argument should be set to `true`. Two test cases are included to exercise the code path.
> 
> Passed tiers 1 - 4 testing.

Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:

  add comments to boolean args

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/15132/files
  - new: https://git.openjdk.org/jdk/pull/15132/files/3435ed5c..aa44f73a

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=15132&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15132&range=00-01

  Stats: 4 lines in 1 file changed: 2 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/15132.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/15132/head:pull/15132

PR: https://git.openjdk.org/jdk/pull/15132


More information about the hotspot-runtime-dev mailing list