RFR: 8313435: Clean up unused default methods code [v5]

[Ioi Lam]

On Thu, 3 Aug 2023 12:25:50 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Default methods processing code has unused code (that gets -Wconversion warnings) from when it was used to create bridge (called overpass) method for an early implementation of generic reification in Hotspot.
>> 
>> This change removes unused bytecodeAssembler code and adds a check for methods and constant pool overflow.
>> Tested with tier1 and runtime/lambda-features tests.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Make assert an exception.

src/hotspot/share/classfile/bytecodeAssembler.cpp line 51:

> 49:     index = *probe;
> 50:   }
> 51:   return static_cast<u2>(index + _orig->length());

The two static_cast<u2>'s should be changed to checked_cast<u2> since we know that we will never truncate.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15095#discussion_r1283886642