RFR: 8313435: Clean up unused default methods code [v5]

[David Holmes]

On Fri, 4 Aug 2023 01:41:26 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> It was my suggestion, because otherwise this code would be returning junk on overflow, leading to invalid code being stored in the buffer.

Okay but how do we arrive at that point? This is an internal implementation detail. We should be able to pre-check the capacity and reject higher-up rather than having the lowest method try to throw the exception (the lowest method should just assert). The profilteration of TRAPS and CHECK really looks ugly here.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15095#issuecomment-1664931338