RFR: JDK-8313781: Add regression tests for large page logging and user-facing error messages [v3]

[Stefan Johansson]

On Tue, 15 Aug 2023 15:11:52 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> In preparation for the UseSHM removal (https://bugs.openjdk.org/browse/JDK-8310841) I'd like more regression tests. 
>> 
>> The new test basically checks the behavior of the JVM when confronted with different variations of:
>> - OS capabilities
>> - JVM settings.
>> 
>> For example: If the JVM is started with -XX:+UseLargePages, but on the OS side there are no huge pages configured, or the kernel does not even support hugepages, the JVM should disable large pages and issue a warning.
>
> Thomas Stuefe has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
> 
>  - Merge branch 'JDK-8313781-Add-regression-tests-for-large-page-logging-and-user-facing-error-messages' of github.com:tstuefe/jdk into JDK-8313781-Add-regression-tests-for-large-page-logging-and-user-facing-error-messages
>  - skip empties
>    
>    Co-authored-by: Stefan Johansson <54407259+kstefanj at users.noreply.github.com>
>  - Remove THPmode unknown
>  - Several test fixes
>  - erge branch 'master' into JDK-8313781-Add-regression-tests-for-large-page-logging-and-user-facing-error-messages
>  - JDK-8313781-Add-regression-tests-for-large-page-logging-and-user-facing-error-messages

Great amount of testing, thanks! 

I also made 3 more suggestions as the other one for the else ifs. Forgot that one could integrate them directly so just did one last time.

test/hotspot/jtreg/runtime/os/TestHugePageDecisionsAtVMStartup.java line 122:

> 120:         }
> 121: 
> 122:         else if (useLP && useTHP && !configuration.supportsTHP()) {

Suggestion:

        } else if (useLP && useTHP && !configuration.supportsTHP()) {

test/hotspot/jtreg/runtime/os/TestHugePageDecisionsAtVMStartup.java line 126:

> 124:         }
> 125: 
> 126:         else if (useLP && !useTHP &&

Suggestion:

        } else if (useLP && !useTHP &&

test/hotspot/jtreg/runtime/os/TestHugePageDecisionsAtVMStartup.java line 133:

> 131:         }
> 132: 
> 133:         else if (useLP && useTHP && configuration.supportsTHP()) {

Suggestion:

        } else if (useLP && useTHP && configuration.supportsTHP()) {

-------------

Marked as reviewed by sjohanss (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15159#pullrequestreview-1582532430
PR Review Comment: https://git.openjdk.org/jdk/pull/15159#discussion_r1297165389
PR Review Comment: https://git.openjdk.org/jdk/pull/15159#discussion_r1297165764
PR Review Comment: https://git.openjdk.org/jdk/pull/15159#discussion_r1297166007