RFR: 8314684: Add overview docs to loaderConstraints.cpp [v2]
Ioi Lam
iklam at openjdk.org
Tue Aug 22 22:08:17 UTC 2023
On Tue, 22 Aug 2023 11:13:00 GMT, David Holmes <dholmes at openjdk.org> wrote:
> Well it reads really well and is informative, but is it correct? Hard to evaluate. It would be clearer if the commentary tied into the code more so that I knew where to see each of the things mentioned, and also understand how the different types (LoaderConstraint, ConstraintSet) fit in that description.
>
> Thanks.
I added ConstraintSet to the comments. I also added references to the `add_entry` and `check_or_update` functions which are the main entry points.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/15372#issuecomment-1688973770
More information about the hotspot-runtime-dev
mailing list