RFR: 8321474: TestAutoCreateSharedArchiveUpgrade.java should be updated with JDK 21 [v2]
Matias Saavedra Silva
matsaave at openjdk.org
Thu Dec 7 22:24:17 UTC 2023
On Thu, 7 Dec 2023 22:08:14 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/TestAutoCreateSharedArchiveUpgrade.java line 94:
>>
>>> 92: doTest();
>>> 93: } catch (RuntimeException e) {
>>> 94: throw new RuntimeException("Invalid AutoCreateSharedArchive JDK version: " + versions[i]);
>>
>> If catching a general exception here you should now add that as the cause of the new one.
>
> But why did you change this anyway?
I figured I needed to catch the exception thrown by `setupJVMs()` but that isn't necessary. I will revert this.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17005#discussion_r1419721718
More information about the hotspot-runtime-dev
mailing list