RFR: 8321474: TestAutoCreateSharedArchiveUpgrade.java should be updated with JDK 21 [v2]

[David Holmes]

On Thu, 7 Dec 2023 21:26:51 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixed check for invalid JDK version
>
> test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/TestAutoCreateSharedArchiveUpgrade.java line 94:
> 
>> 92:                 doTest();
>> 93:             } catch (RuntimeException e) {
>> 94:                 throw new RuntimeException("Invalid AutoCreateSharedArchive JDK version: " + versions[i]);
> 
> If catching a general exception here you should now add that as the cause of the new one.

But why did you change this anyway?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17005#discussion_r1419712303