RFR: 8321539: Minimal build is broken by JDK-8320935

Matthias Baesken mbaesken at openjdk.org
Fri Dec 8 09:22:13 UTC 2023


On Thu, 7 Dec 2023 17:02:09 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> Please review this trivial fix. `CDSConfig::check_vm_args_consistency()` should trivially return `true` on platforms that don't support CDS

Thanks for the fix.   This fixes also the AIX build (the AIX build was broken after JDK-8320935) .
I still have a question - why is the cds related coding in arguments.cpp (e.g. `CDSConfig::check_system_property(key, value)` );
not guarded by
` #if INCLUDE_CDS`  ?

-------------

Marked as reviewed by mbaesken (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17020#pullrequestreview-1771917615


More information about the hotspot-runtime-dev mailing list