RFR: 8321539: Minimal build is broken by JDK-8320935
Ioi Lam
iklam at openjdk.org
Fri Dec 8 17:28:21 UTC 2023
On Fri, 8 Dec 2023 09:19:56 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
> Thanks for the fix. This fixes also the AIX build (the AIX build was broken after JDK-8320935) . I still have a question - why is the cds related coding in arguments.cpp (e.g. `CDSConfig::check_system_property(key, value)` ); not guarded by `#if INCLUDE_CDS` ?
We usually use the `NOT_CDS_XXX` macros in the header files to provide dummy implementations when CDS is not enabled. This avoids the proliferation of `#if INCLUDE_CDS` in the source code.
Thanks @MBaesken @matias9927 @calvinccheung for the review.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/17020#issuecomment-1847559444
PR Comment: https://git.openjdk.org/jdk/pull/17020#issuecomment-1847559939
More information about the hotspot-runtime-dev
mailing list