RFR: 8321933: TestCDSVMCrash.java spawns two processes
Matias Saavedra Silva
matsaave at openjdk.org
Wed Dec 13 21:27:49 UTC 2023
TestCDSVMCrash.java looks like it spawns two processes, once in the pb.start() call and then again in executeAndLog:
OutputAnalyzer output = new OutputAnalyzer(pb.start());
// executeAndLog should throw an exception in the VM crashed
try {
CDSTestUtils.executeAndLog(pb, "cds_vm_crash");
The test redundantly checks the result of the output since the expected exception will only be thrown if the checked conditions are true.
Note that fixing the indentation makes the diff hard to read, so I recommend looking at each commit separately.
-------------
Commit messages:
- Fixed indentation
- 8321933: TestCDSVMCrash.java spawns two processes
Changes: https://git.openjdk.org/jdk/pull/17092/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=17092&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8321933
Stats: 33 lines in 1 file changed: 1 ins; 6 del; 26 mod
Patch: https://git.openjdk.org/jdk/pull/17092.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/17092/head:pull/17092
PR: https://git.openjdk.org/jdk/pull/17092
More information about the hotspot-runtime-dev
mailing list