RFR: 8321933: TestCDSVMCrash.java spawns two processes

[Calvin Cheung]

On Wed, 13 Dec 2023 20:40:02 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

> TestCDSVMCrash.java looks like it spawns two processes, once in the pb.start() call and then again in executeAndLog:
> 
>          OutputAnalyzer output = new OutputAnalyzer(pb.start());
>          // executeAndLog should throw an exception in the VM crashed
>          try {
>             CDSTestUtils.executeAndLog(pb, "cds_vm_crash");
> 
> The test redundantly checks the result of the output since the expected exception will only be thrown if the checked conditions are true.
> 
> Note that fixing the indentation makes the diff hard to read, so I recommend looking at each commit separately.

LGTM.

-------------

Marked as reviewed by ccheung (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17092#pullrequestreview-1780555989