RFR: JDK-8302102: Disable ASan for SafeFetch and os::print_hex_dump

Thomas Stuefe stuefe at openjdk.org
Fri Feb 10 05:19:45 UTC 2023


On Wed, 8 Feb 2023 20:12:06 GMT, Justin King <jcking at openjdk.org> wrote:

> Disable ASan instrumentation for non-assembly versions of SafeFetch and os::print_hex_dump.

src/hotspot/os/windows/safefetch_windows.hpp line 35:

> 33: 
> 34: template <class T>
> 35: ATTRIBUTE_NO_SANITIZE_ADDRESS static inline T SafeFetchXX(const T* adr, T errValue) {

Wait, why is this static now?

src/hotspot/share/sanitizers/address.hpp line 32:

> 30: #endif
> 31: 
> 32: // ATTRIBUTE_NO_SANITIZE_ADDRESS

Can we find a better name for this? Its lengthy but still not very clear. E.g. as a prefix to a function it reads like it does something to the - should there be one - return pointer of the function.

proposal: ASAN_DISABLE

-------------

PR: https://git.openjdk.org/jdk/pull/12477


More information about the hotspot-runtime-dev mailing list