RFR: JDK-8302102: Disable ASan for SafeFetch and os::print_hex_dump [v2]

Thomas Stuefe stuefe at openjdk.org
Sat Feb 11 07:30:28 UTC 2023


On Fri, 10 Feb 2023 19:38:34 GMT, Justin King <jcking at openjdk.org> wrote:

>> src/hotspot/share/sanitizers/address.hpp line 32:
>> 
>>> 30: #endif
>>> 31: 
>>> 32: // ATTRIBUTE_NO_SANITIZE_ADDRESS
>> 
>> Can we find a better name for this? Its lengthy but still not very clear. E.g. as a prefix to a function it reads like it does something to the - should there be one - return pointer of the function.
>> 
>> proposal: ASAN_DISABLE
>
> I was mostly going for being consistent with other uses in globalDefinitions. Most things are ATTRIBUTE_X where X is the actual attribute name.
> 
> Maybe ATTRIBUTE_NO_ASAN if we want something shorter?

Sounds good.

-------------

PR: https://git.openjdk.org/jdk/pull/12477


More information about the hotspot-runtime-dev mailing list