RFR: JDK-8301990: Separate Arguments::parse into two phases [v2]

David Holmes dholmes at openjdk.org
Tue Feb 14 06:39:47 UTC 2023


On Mon, 13 Feb 2023 17:48:50 GMT, Justin King <jcking at openjdk.org> wrote:

>> Separate out some logic from `Arguments::parse` into a separate preceding phase, preprocessing. See JDK-8301990 and JDK-8299196 for more details.
>
> Justin King has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Updates based on review
>   
>   Signed-off-by: Justin King <jcking at google.com>

src/hotspot/share/runtime/arguments.cpp line 3788:

> 3786: static const char* const hotspotrc = ".hotspotrc";
> 3787: 
> 3788: class Arguments::PreprocessedImpl final : public CHeapObj<mtArguments> {

I preferred this named `PrepProcessedArguments`. I don't see why you needed to change this name to get rid of the void* field ???

-------------

PR: https://git.openjdk.org/jdk/pull/12458


More information about the hotspot-runtime-dev mailing list