RFR: JDK-8301990: Separate Arguments::parse into two phases [v2]

[Justin King]

On Tue, 14 Feb 2023 06:34:53 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Justin King has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Updates based on review
>>   
>>   Signed-off-by: Justin King <jcking at google.com>
>
> src/hotspot/share/runtime/arguments.cpp line 3788:
> 
>> 3786: static const char* const hotspotrc = ".hotspotrc";
>> 3787: 
>> 3788: class Arguments::PreprocessedImpl final : public CHeapObj<mtArguments> {
> 
> I preferred this named `PrepProcessedArguments`. I don't see why you needed to change this name to get rid of the void* field ???

I can go with `PreprocessedArguments`. kimbarrett@ suggested getting rid of void* to avoid casting. I can just predeclare as PreprocessedArguments.

-------------

PR: https://git.openjdk.org/jdk/pull/12458