RFR: 8295344: Harden runtime/StackGuardPages/TestStackGuardPages.java [v2]
Robbin Ehn
rehn at openjdk.org
Tue Feb 14 13:11:48 UTC 2023
On Thu, 9 Feb 2023 13:37:58 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:
>> There are multiple ways which the stack guard pages tests can be hardened:
>> - Rewritten the Java part of the test using ProcessTools.executeProcess(ProcessBuilder pb) which will make stdout/stderr be consistently logged and debugging much easier.
>> - Split up initial/other thread into 2 tests
>> - Split up Java thread tests and native thread tests into two separate files
>> - Check more error conditions in the C code
>> - Instead of recursing and creating stack frames, just `alloca()` and poke until we hit a `SIGSEGV`.
>>
>> The goal is that this will help us out with [JDK-8293452](https://bugs.openjdk.org/browse/JDK-8293452).
>
> Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
>
> Remove from ProblemList.txt
Seems ok!
-------------
Marked as reviewed by rehn (Reviewer).
PR: https://git.openjdk.org/jdk/pull/12386
More information about the hotspot-runtime-dev
mailing list