Integrated: 8295344: Harden runtime/StackGuardPages/TestStackGuardPages.java

Johan Sjölen jsjolen at openjdk.org
Tue Feb 14 13:14:55 UTC 2023


On Thu, 2 Feb 2023 12:35:10 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

> There are multiple ways which the stack guard pages tests can be hardened:
> - Rewritten the Java part of the test using ProcessTools.executeProcess(ProcessBuilder pb) which will make stdout/stderr be consistently logged and debugging much easier.
> - Split up initial/other thread into 2 tests
> - Split up Java thread tests and native thread tests into two separate files
> - Check more error conditions in the C code
> - Instead of recursing and creating stack frames, just `alloca()` and poke until we hit a `SIGSEGV`.
> 
> The goal is that this will help us out with  [JDK-8293452](https://bugs.openjdk.org/browse/JDK-8293452).

This pull request has now been integrated.

Changeset: 8c2c8b3f
Author:    Johan Sjölen <jsjolen at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/8c2c8b3f7f1bf286ca67a736938797d14fd7555c
Stats:     152 lines in 4 files changed: 96 ins; 30 del; 26 mod

8295344: Harden runtime/StackGuardPages/TestStackGuardPages.java

Reviewed-by: dholmes, rehn

-------------

PR: https://git.openjdk.org/jdk/pull/12386


More information about the hotspot-runtime-dev mailing list