RFR: JDK-8301990: Separate Arguments::parse into two phases [v3]

[David Holmes]

On Wed, 15 Feb 2023 16:21:01 GMT, Justin King <jcking at openjdk.org> wrote:

>> src/hotspot/share/runtime/arguments.cpp line 3796:
>> 
>>> 3794:                             mod_vm_options_args("vm_options_args"),
>>> 3795:                             mod_java_tool_options_args("env_var='JAVA_TOOL_OPTIONS'"),
>>> 3796:                             mod_java_options_args("env_var='_JAVA_OPTIONS'") {}
>> 
>> Indentation is off - args should align on the `"` of the first arg.
>
> How do you mean? Like do not align the variables, but align the arguments, or both? Do you have an example?

Never mind - seems to be a glitch in the way the diff is presented. The actual file content appears fine.

-------------

PR: https://git.openjdk.org/jdk/pull/12458