RFR: JDK-8301990: Separate Arguments::parse into two phases [v3]
Justin King
jcking at openjdk.org
Wed Feb 15 16:24:37 UTC 2023
On Wed, 15 Feb 2023 04:47:08 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Justin King has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Rename PreprocessedImpl to PreprocessedArguments
>>
>> Signed-off-by: Justin King <jcking at google.com>
>
> src/hotspot/share/runtime/arguments.cpp line 3796:
>
>> 3794: mod_vm_options_args("vm_options_args"),
>> 3795: mod_java_tool_options_args("env_var='JAVA_TOOL_OPTIONS'"),
>> 3796: mod_java_options_args("env_var='_JAVA_OPTIONS'") {}
>
> Indentation is off - args should align on the `"` of the first arg.
How do you mean? Like do not align the variables, but align the arguments, or both? Do you have an example?
-------------
PR: https://git.openjdk.org/jdk/pull/12458
More information about the hotspot-runtime-dev
mailing list