RFR: JDK-8301990: Separate Arguments::parse into two phases [v3]

Thomas Stuefe stuefe at openjdk.org
Thu Feb 16 10:58:30 UTC 2023


On Tue, 14 Feb 2023 16:10:42 GMT, Justin King <jcking at openjdk.org> wrote:

>> Separate out some logic from `Arguments::parse` into a separate preceding phase, preprocessing. See JDK-8301990 and JDK-8299196 for more details.
>
> Justin King has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Rename PreprocessedImpl to PreprocessedArguments
>   
>   Signed-off-by: Justin King <jcking at google.com>

I am not convinced that the reason behind this change - getting rid of NMTPreInit - is something we should do. See my comments under https://bugs.openjdk.org/browse/JDK-8299196. I think we should discuss that first.

I did not look at this patch to see if it has merits beyond that.

-------------

PR: https://git.openjdk.org/jdk/pull/12458


More information about the hotspot-runtime-dev mailing list