RFR: 8302781: CDS archive heap not reproducible after JDK-8296344

[Daniel D. Daugherty]

On Sat, 18 Feb 2023 04:27:31 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> [JDK-8296344](https://bugs.openjdk.org/browse/JDK-8296344) changed the order of when `oopDesc::identity_hash()` is called for the archived heap object.
> 
> This one-liner fix restores the order, so that we initialize the `identity_hash` part of the archived object headers predictably.
> 
> Please see [my comment in the JBS report](https://bugs.openjdk.org/browse/JDK-8302781?focusedCommentId=14561163&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14561163) for details.

Thumbs up. One very minor typo. This is a trivial fix and does not
need to wait 24 hours.

src/hotspot/share/cds/heapShared.cpp line 290:

> 288: 
> 289:     // The archived objects are discovered in a predictable order. Compute
> 290:     // their identity_hash() as soon as we see them. This ensure that the

nit typo: s/This ensure/This ensures/

-------------

Marked as reviewed by dcubed (Reviewer).

PR: https://git.openjdk.org/jdk/pull/12628