RFR: 8302781: CDS archive heap not reproducible after JDK-8296344 [v2]

Ioi Lam iklam at openjdk.org
Sun Feb 19 06:04:02 UTC 2023


On Sat, 18 Feb 2023 14:14:06 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fixed typo
>
> Thumbs up. One very minor typo. This is a trivial fix and does not
> need to wait 24 hours.

Thanks @dcubed-ojdk for the review.
Passed builds-tier5 (where the original failure was detected). Also passed tiers 1 and 2.

> src/hotspot/share/cds/heapShared.cpp line 290:
> 
>> 288: 
>> 289:     // The archived objects are discovered in a predictable order. Compute
>> 290:     // their identity_hash() as soon as we see them. This ensure that the
> 
> nit typo: s/This ensure/This ensures/

Fixed.

-------------

PR: https://git.openjdk.org/jdk/pull/12628


More information about the hotspot-runtime-dev mailing list