RFR: 8288912: vmTestbase/nsk/stress/strace/strace002.java fails with Unexpected method name: currentCarrierThread [v3]

Leonid Mesnik lmesnik at openjdk.org
Wed Feb 22 00:16:28 UTC 2023


On Mon, 20 Feb 2023 01:51:46 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   doc updated
>
> test/hotspot/jtreg/vmTestbase/nsk/stress/strace/StraceBase.java line 56:
> 
>> 54:         String className = element.getClassName();
>> 55:         String methodName = element.getMethodName();
>> 56:         if (!isValidJavaName(className) || !isValidJavaName(methodName)) {
> 
> You've pulled the class and method names out of a stacktrace element - how can they not be valid java names ???

See my other comment. The tests doesn't always check names and methods so at least it is needed to verify that they are not some arbitrary string.

-------------

PR: https://git.openjdk.org/jdk/pull/12638


More information about the hotspot-runtime-dev mailing list