RFR: 8288912: vmTestbase/nsk/stress/strace/strace002.java fails with Unexpected method name: currentCarrierThread [v3]

David Holmes dholmes at openjdk.org
Wed Feb 22 00:36:38 UTC 2023


On Wed, 22 Feb 2023 00:13:54 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> test/hotspot/jtreg/vmTestbase/nsk/stress/strace/StraceBase.java line 56:
>> 
>>> 54:         String className = element.getClassName();
>>> 55:         String methodName = element.getMethodName();
>>> 56:         if (!isValidJavaName(className) || !isValidJavaName(methodName)) {
>> 
>> You've pulled the class and method names out of a stacktrace element - how can they not be valid java names ???
>
> See my other comment. The tests doesn't always check names and methods so at least it is needed to verify that they are not some arbitrary string.

But they have to be valid names barring some kind of native memory corruption, in which case you could be broken in a million different ways.

-------------

PR: https://git.openjdk.org/jdk/pull/12638


More information about the hotspot-runtime-dev mailing list