RFR: 8303082 : [AIX] Missing C++ name demangling with XLClang++

[Tyler Steele]

On Fri, 24 Feb 2023 15:16:08 GMT, Deepa Kumari <duke at openjdk.org> wrote:

> It was failing as It was using the C++ demangling interface (Demangle) of the old demangler (that is, the C++ API as opposed to the C one). It is not supported by xlclang++ on AIX.
> To demangle names generated by xlclang++ , use cxxabi.h __cxa_demangle interface ( see cxxabi.h).
> 
> This Solution applies to the following test 
> 
> 1. SecondaryErrorTest.java`
> 2. TestSigInfoInHsErrFile.java
> 
> 
> Reported Issue : [JDK - 8303082](https://bugs.openjdk.org/browse/JDK-8303082)

Changes requested by tsteele (Committer).

Thanks for looking at this Deepa! This fixes an issue that I had always noticed, but never got around to digging in to :-)

src/hotspot/os/aix/porting_aix.cpp line 242:

> 240: 	int status;
> 241: 	char *demangled_name = abi::__cxa_demangle(p_name, NULL, NULL, &status);
> 242:         if ((demangled_name != NULL) && (status == 0)) {

Please change these NULLs to nullptr. There is an ongoing effort to eliminate NULL in the codebase; I believe simply swapping NULL for nullptr is appropriate here.

-------------

PR: https://git.openjdk.org/jdk/pull/12742