RFR: 8303082 : [AIX] Missing C++ name demangling with XLClang++

Deepa Kumari duke at openjdk.org
Mon Feb 27 06:40:55 UTC 2023


On Fri, 24 Feb 2023 16:37:26 GMT, Tyler Steele <tsteele at openjdk.org> wrote:

> Thanks for looking at this Deepa! This fixes an issue that I had always noticed, but never got around to digging in to :-)

Thank you @backwaterred .

> src/hotspot/os/aix/porting_aix.cpp line 242:
> 
>> 240: 	int status;
>> 241: 	char *demangled_name = abi::__cxa_demangle(p_name, NULL, NULL, &status);
>> 242:         if ((demangled_name != NULL) && (status == 0)) {
> 
> Please change these NULLs to nullptr. There is an ongoing effort to eliminate NULL in the codebase; I believe simply swapping NULL for nullptr is appropriate here.

I will modify these NULLs to nullptr. Thank you @backwaterred for pointing out this.

-------------

PR: https://git.openjdk.org/jdk/pull/12742


More information about the hotspot-runtime-dev mailing list