RFR: 8299343: Windows: Invalid thread_native_entry declaration
Kim Barrett
kbarrett at openjdk.org
Thu Jan 5 21:32:59 UTC 2023
On Thu, 5 Jan 2023 03:00:04 GMT, David Holmes <dholmes at openjdk.org> wrote:
> > I'm now a little curious as to why we couldn't make create_process_or_thread and Ept public though
>
> To get rid of the friend declaration there were two options - Kim prefers the one he presented.
I preferred moving the function into the class to avoid widening the public
API of the class to provide access to what is really an implementation detail
of the class. Of course, having os::win32 already befriending os helped. (We
resort to friendship way too often :( )
-------------
PR: https://git.openjdk.org/jdk/pull/11787
More information about the hotspot-runtime-dev
mailing list