RFR: 8299343: Windows: Invalid thread_native_entry declaration [v2]

Kim Barrett kbarrett at openjdk.org
Thu Jan 5 22:07:38 UTC 2023


On Tue, 3 Jan 2023 06:40:58 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Kim Barrett has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Merge branch 'master' into thread_native_entry
>>  - missing period
>>  - use static member function
>
> src/hotspot/os/windows/os_windows.cpp line 514:
> 
>> 512: 
>> 513: // Thread start routine for all newly created threads
>> 514: // Called with the associated Thread* as the argument.
> 
> Nit: please terminate existing comment with a period - thanks.

Done.

-------------

PR: https://git.openjdk.org/jdk/pull/11787


More information about the hotspot-runtime-dev mailing list