RFR: 8285850 : [AIX] unreachable code in basic_tools.m4 -> BASIC_CHECK_TAR

[Deepa Kumari]

On Mon, 23 Jan 2023 16:47:47 GMT, Deepa Kumari <duke at openjdk.org> wrote:

> basic_tools.m4 contains the line 'elif test "x$TAR_TYPE" = "aix";...' The comparison "x$TAR_TYPE" = "aix" can never be true. Adding an 'x' to both sides of the comparison prevents an erroneous match when the variable is the empty string.
> 
> Verified the test after successful build and reflecting changes 'elif test "x$TAR_TYPE" = "xaix";...' on generated-configure.sh file.
> 
> Reported Issue : [JDK-8285850](https://bugs.openjdk.org/browse/JDK-8285850)

> Hi @deepa181, welcome to this OpenJDK project and thanks for contributing!
> 
> We do not recognize you as [Contributor](https://openjdk.java.net/bylaws#contributor) and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow [the instructions](https://oca.opensource.oracle.com/). Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing `/signed` in a comment in this pull request.
> 
> If you already are an OpenJDK [Author](https://openjdk.java.net/bylaws#author), [Committer](https://openjdk.java.net/bylaws#committer) or [Reviewer](https://openjdk.java.net/bylaws#reviewer), please click [here](https://bugs.openjdk.java.net/secure/CreateIssue.jspa?pid=11300&issuetype=1) to open a new issue so that we can record that fact. Please use "Add GitHub user deepa181" as summary for the issue.
> 
> If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing `/covered` in a comment in this pull request.

-------------

PR: https://git.openjdk.org/jdk/pull/12146