RFR: 8285850 : [AIX] unreachable code in basic_tools.m4 -> BASIC_CHECK_TAR

Thu Jan 26 23:13:15 UTC 2023

On Mon, 23 Jan 2023 16:47:47 GMT, Deepa Kumari <duke at openjdk.org> wrote:

> basic_tools.m4 contains the line 'elif test "x$TAR_TYPE" = "aix";...' The comparison "x$TAR_TYPE" = "aix" can never be true. Adding an 'x' to both sides of the comparison prevents an erroneous match when the variable is the empty string.
> 
> Verified the test after successful build and reflecting changes 'elif test "x$TAR_TYPE" = "xaix";...' on generated-configure.sh file.
> 
> Reported Issue : [JDK-8285850](https://bugs.openjdk.org/browse/JDK-8285850)

That is indeed a mistake, thanks for spotting it. Makes me wonder if the build worked on AIX.

-------------

Marked as reviewed by erikj (Reviewer).

PR: https://git.openjdk.org/jdk/pull/12146