RFR: 8311609: [windows] Native stack printing lacks source information for dynamically loaded dlls

David Holmes dholmes at openjdk.org
Wed Jul 12 21:31:13 UTC 2023


On Fri, 7 Jul 2023 08:24:43 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Details are in the JBS issue, but the tl;dr version is we need to call `SymRefreshModuleList` before printing the native stack to ensure we have recently loaded dll's available. You still need the pdb for those dll's to actually get source information, of course.
>> 
>> Testing:
>> - sanity testing tiers 1-3
>> - local testing on windows in the context of [JDK-8311541](https://bugs.openjdk.org/browse/JDK-8311541)
>> 
>> Thanks
>
> Looks good and straightforward.
> 
> I thought this code looks familiar, then I found that SAP contributed this coding in 2017. It misses SAP copyrights though. If you feel like adding it... (we can do this separately of course).

Thanks for the review @tstuefe ! Please add the SAP copyrights separately - thanks.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14796#issuecomment-1633236036


More information about the hotspot-runtime-dev mailing list