RFR: 8299825: Move StdoutLog and StderrLog to LogConfiguration [v2]

Johan Sjölen jsjolen at openjdk.org
Thu Jun 8 12:52:00 UTC 2023


On Thu, 8 Jun 2023 12:14:52 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> src/hotspot/share/logging/logConfiguration.cpp line 47:
>> 
>>> 45: 
>>> 46: LogStdoutOutput* LogConfiguration::LogConfiguration::StdoutLog = nullptr;
>>> 47: LogStderrOutput* LogConfiguration::LogConfiguration::StderrLog = nullptr;
>> 
>> Why is `LogConfiguration` given twice?
>
> I'm going to guess after you made the initial change you did a global replace that added `LogConfiguration::` to every occurrence of the names - many of which are not needed.

Yes, I accidentally applied the search and replace twice on this file, but missed this particular instance of the issue.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14376#discussion_r1222989757


More information about the hotspot-runtime-dev mailing list