RFR: 8308463: Refactor regenerated class handling in lambdaFormInvokers.cpp [v2]

[Matias Saavedra Silva]

On Thu, 22 Jun 2023 03:52:28 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> The handling of regenerated classes need to be refactored to enable future development:
>> 
>> - Improve the API to access the regenerated classes and their methods
>> - Allow more classes to be regenerated, not just the Lambda Form invokers. Therefore, the code is moved to a new file cds/regeneratedClasses.cpp
>> 
>> 
>> Please see the bug report [JDK-8308463](https://bugs.openjdk.org/browse/JDK-8308463) for motivation of this PR.
>
> Ioi Lam has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - @dholmes-ora comments
>  - @coleenp review comments

Nice refactor! Just one question, otherwise it looks good.

src/hotspot/share/cds/regeneratedClasses.cpp line 61:

> 59:     if (regen_m == nullptr) {
> 60:       ResourceMark rm;
> 61:       log_info(cds, lambda)("Method in original class is missing from regenerated class: " INTPTR_FORMAT " %s",

Should this result in some sort of exception?

-------------

Marked as reviewed by matsaave (Committer).

PR Review: https://git.openjdk.org/jdk/pull/14573#pullrequestreview-1493827980
PR Review Comment: https://git.openjdk.org/jdk/pull/14573#discussion_r1238920856