RFR: 8308463: Refactor regenerated class handling in lambdaFormInvokers.cpp [v2]

[Ioi Lam]

On Thu, 22 Jun 2023 18:59:29 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - @dholmes-ora comments
>>  - @coleenp review comments
>
> src/hotspot/share/cds/regeneratedClasses.cpp line 61:
> 
>> 59:     if (regen_m == nullptr) {
>> 60:       ResourceMark rm;
>> 61:       log_info(cds, lambda)("Method in original class is missing from regenerated class: " INTPTR_FORMAT " %s",
> 
> Should this result in some sort of exception?

Currently the missing methods aren't a problem, as the CDS image will not have any direct references to them. (And if we did, it would result in a crash in ArchiveBuilder::get_buffered_addr(), so we will know pretty quickly).

See https://bugs.openjdk.org/browse/JDK-8310831 for more info.

Anyway, I've changed it to be a warning log so we can be aware of it. Currently, this seems to happen only during the JDK build, when creating intermediate CDS archive files (during which time the warnings are piped to /dev/null so you won't see it .....)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14573#discussion_r1240448420