RFR: 8301715: CDS should be disabled in exploded JDK [v2]

[Matias Saavedra Silva]

On Tue, 28 Feb 2023 00:46:32 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Replaced condition with assert
>
> src/hotspot/share/runtime/arguments.cpp line 2927:
> 
>> 2925:     UseSharedSpaces = false;
>> 2926:     RequireSharedSpaces = false;
>> 2927:   }
> 
> I think you should call `no_shared_spaces()` instead. That way, the VM will print an error message and exit if `-Xshare:on` is specified.

Adding `no_shared_spaces()` here makes sense but it results in a duplicate output. I will move this check up to the caller of this method to avoid redundant logs.

-------------

PR: https://git.openjdk.org/jdk/pull/12705