RFR: 8301715: CDS should be disabled in exploded JDK [v2]

Matias Saavedra Silva matsaave at openjdk.org
Fri Mar 17 22:09:05 UTC 2023


On Wed, 1 Mar 2023 21:35:21 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> src/hotspot/share/runtime/arguments.cpp line 2927:
>> 
>>> 2925:     UseSharedSpaces = false;
>>> 2926:     RequireSharedSpaces = false;
>>> 2927:   }
>> 
>> I think you should call `no_shared_spaces()` instead. That way, the VM will print an error message and exit if `-Xshare:on` is specified.
>
> Adding `no_shared_spaces()` here makes sense but it results in a duplicate output. I will move this check up to the caller of this method to avoid redundant logs.

Fixed!

-------------

PR: https://git.openjdk.org/jdk/pull/12705


More information about the hotspot-runtime-dev mailing list